Fetch timers separately for xiaomi vacuums#41330
Merged
balloob merged 1 commit intohome-assistant:devfrom Oct 6, 2020
Merged
Conversation
Some xiaomi vacuum devices (S50?) do not respond properly to timer requests, causing the whole update cycle fail and leaving the device unavailable. This PR moves the timer fetching into its own try-except block, making the integration usable w/o timer information. Fixes home-assistant#38285
probot-home-assistant
Bot
added
Hacktoberfest
bugfix
integration: xiaomi_miio
small-pr
|
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
|
Hey there @syssi, @starkillerOG, mind taking a look at this pull request as its been labeled with an integration ( |
balloob
approved these changes
Oct 6, 2020
|
@balloob When is this fix going to be published in a release? |
Contributor
|
Please refrain from tagging people is not actually necessary. Since it is not tagged for 0.116.4 it will probably land in 0.117. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Some xiaomi vacuum devices (S50?) do not respond properly to timer requests,
causing the whole update cycle fail and leaving the device unavailable.
This PR moves the timer fetching into its own try-except block, making the integration usable w/o timer information.
Fixes #38285
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: